search

jslovers / jslovers-branding-page

MIT License
6 stars 22 forks source link

Fix: responsive design and add gototop button #31

Closed vctc closed 1 month ago

vctc commented 1 year ago

Make the webpage responsive #15

vctc commented 1 year ago

@Neha I have resolved the conflicts. Can you please merge this PR if there is no other issues?

vctc commented 1 year ago

@Neha It is better to add prettier configuration in the project. So that anyone who checkouts and save will format the code consistantly.

vctc commented 1 year ago

@Neha May I know the reason why this PR is not merged into main. Anything I need to address in my code changes?

Neha commented 1 year ago

@Neha May I know the reason why this PR is not merged into main. Anything I need to address in my code changes?

Hey @vctc I was trying to review as many as PR I can. I will do rest over the weekend. Hence, there is a delay

Neha commented 11 months ago

@Neha It is better to add prettier configuration in the project. So that anyone who checkouts and save will format the code consistantly.

Thank you for your suggestion. I have added it and it is available in the main branch. Please feel free to suggest new rules