search

jslovers / jslovers-official-website

JSLovers Official Website built on Next.js
MIT License
53 stars 47 forks source link

Changed the Logo #71

Closed akshat99812 closed 2 weeks ago

akshat99812 commented 2 weeks ago

Fixes #60

Type of change

Neha commented 2 weeks ago

Hello @akshat99812 ,

I saw you are first time contributor.

So, here are few things to take care:

  1. Please do not delete the PR template. if you are not sure about what to fill, then please leave it blank
  2. As now the image is coming from SVG path. Do we need the image?
  3. I have requested you to not to commit package.json (lock).
  4. Please do not close the PR and raise new PR for every change. Push new changes in the already open PR.

If you have any question. Please reach out to me over discord. Link is in repo's readme

Thanks, Neha

akshat99812 commented 2 weeks ago

Thank you for the guidance and feedback! I appreciate the detailed instructions. Please let me know if there's anything else I should be aware of.

Neha commented 2 weeks ago

Thank you for the guidance and feedback! I appreciate the detailed instructions. Please let me know if there's anything else I should be aware of.

Welcome. Please review this PR: https://github.com/jslovers/jslovers-official-website/pull/73 it will help you to understand what were the changes

I went ahead and did the changes. Please feel free to pick any other issue.