jslovers / jslovers-official-website

JSLovers Official Website built on Next.js
MIT License
53 stars 47 forks source link

Code improvements Suggestions [WIP] #74

Open Neha opened 2 weeks ago

Neha commented 2 weeks ago

Describe the bug This would be a list of code improvements to do in the code:

  1. Create a reusable component of "form". "Enter your email" section is required more than 2 places.
  2. Homepage -> Previous talk section can be break into small component. map logic should be outside JSX as a separate function
  3. Homepage -> Form on homepage should be a separate component
  4. Homepage -> Some content is hard coded and some is coming from config. Need to sort this out
  5. Header component -> Requires code optimizations. The HTML can be optimize by removing extra DIV and Make 3 different components: LOGO, Nav, and Register Button.
  6. Footer: map should be outside JSX

A few issues can be taken care with this issue:

https://github.com/jslovers/jslovers-official-website/issues/72 https://github.com/jslovers/jslovers-official-website/issues/63 https://github.com/jslovers/jslovers-official-website/issues/58

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.