jslovers / jslovers-official-website

JSLovers Official Website built on Next.js
MIT License
53 stars 47 forks source link

Code: Page rename - fixes #62 #76

Closed vignesh-murugan-dev closed 2 weeks ago

vignesh-murugan-dev commented 2 weeks ago

Description

Renamed all pages from XPageIndex to XPage Fixes #62

Updates:

  1. (marketing) IndexPage - refactored arrow function expression to function declaration to maintain consistent usage across all pages
  2. collaboration - renamed function name from 'page' to 'CollaborationPage'
  3. meetups - renamed function name from 'SpeakerIndexPage' to 'MeetupsPage'
  4. speakers - renamed function name from 'SpeakersIndexPage' to 'SpeakersPage'

Snapshots/Videos:

Type of change

Added tests?

Internationalization Support?

Steps to test the feature:

Snapshot of the test-cases that are passing:

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Neha commented 2 weeks ago

Hey @vignesh-murugan-dev thank you for your PR. Name should be just page not speakerPage. etc. Can you please do the needful changes

vignesh-murugan-dev commented 2 weeks ago

Hi @Neha thanks for the review. I made the necessary changes, please check them and do what is needed.