jslovers / jslovers-official-website

JSLovers Official Website built on Next.js
MIT License
53 stars 47 forks source link

CI (Continuous Integration) pipeline added #79

Open akshat99812 opened 2 weeks ago

akshat99812 commented 2 weeks ago

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

This pull request introduces a CI (Continuous Integration) pipeline to our project. The CI pipeline automates the process of testing and building our codebase, ensuring that code changes are validated and merged seamlessly. This enhancement addresses issue #3 and aims to improve our development workflow by catching potential issues early.

Fixes #3

Snapshots/Videos:

Screenshot 2024-06-18 at 3 49 17 PM

Type of change

Added tests?

Internationalization Support?

Steps to test the feature:

Snapshot of the test-cases that are passing:

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

akshat99812 commented 2 weeks ago

@Neha

Screenshot 2024-06-19 at 1 30 07 PM

there are some linter errors that were fixed in abut/page.tsx and jobs/page.tsx

Neha commented 2 weeks ago

@Neha Screenshot 2024-06-19 at 1 30 07 PM there are some linter errors that were fixed in abut/page.tsx and jobs/page.tsx

The whole purpose of having Eslint, and Prettier in CI is to get such errors and fix them. Putting the files in gitignore to ignore these errors will not serve any purpose.

Neha commented 3 days ago

Hey @akshat99812 would you be able to work on the code comments?

akshat99812 commented 3 days ago

@Neha Sure, I'd be happy to help! Could you please clarify what specific tasks you want me to work on regarding the code comments? For example, are you looking for me to add comments to existing code, review and improve current comments, or something else?

Neha commented 2 days ago

@Neha Sure, I'd be happy to help! Could you please clarify what specific tasks you want me to work on regarding the code comments? For example, are you looking for me to add comments to existing code, review and improve current comments, or something else?

I didn't got your question. Anyhow, this is how the OS works - There are comments added for your PR. Please go through the comments and fix your PR accordingly.

Siddhant-K-code commented 2 days ago

Could you please clarify what specific tasks you want me to work on regarding the code comments? For example, are you looking for me to add comments to existing code, review and improve current comments, or something else?

Hey @akshat99812, we are just suggesting to address the PR review comments that Neha & I left above