search

jslusser / ListeningToBodies

MIT License
0 stars 1 forks source link

Prototype of converting to table view #2

Open ryantstone opened 5 years ago

ryantstone commented 5 years ago

This is a work in progress. I converted the text to JSON (probably over did it, could easily be bigger chunks). I did change the navigation for easier debugging. Next I need to work on creating the heterogeneous collection that conforms to Block that will allow the collection to have any type.

Also, depending on the format of the text you have if it is in or can easily be converted to Markdown you could easily format all text using a markdown converter plugin. (https://github.com/iwasrobbed/Down)

jslusser commented 5 years ago

Thank you very much for this. I do 99.9% of my work inside Xcode and rarely look at Github, so I am just now seeing that you created this pull request 12 days ago. I was quietly waiting on a response in Slack and assumed you were too busy to help me 🤦‍♂️. Now for my next stupid question, I don't know GitHub well enough to really see what you did, and I have subsequently made more changes to Master. I can look at the files changes, but I'm much more comfortable reviewing code in Xcode. There are now conflicts, and I'm kind of afraid to merge them without knowing what will happen. Is there a way for me to download your Pull Request into gitHub so I can look at the code? Or should I try to merge them (and attempt to resolve the conflicts) and then revert back to a previous version if something goes horribly wrong? I'm excited to learn from your example and attempt to make it work. Also I've have very spotty WiFi since we last connected, so that's been another challenge.

ryantstone commented 5 years ago

My turn to have not seen this. To manage conflicts I'd need to rebase my branch on your master (might be ugly). But as for looking at what I did you could checkout my branch (https://help.github.com/en/articles/checking-out-pull-requests-locally) or look at the Files Changed tab above. Most of what I did was in code so you should be able to read through and get the gist of what I was doing, if you have questions hit me up on Slack or if you're there tomorrow we can talk about it.