jsm174 / vpx-standalone-scripts

Table patches for VPX Standalone
https://github.com/vpinball/vpinball/tree/standalone/
29 stars 15 forks source link

Standalone - Total Nuclear Annihilation - plastics / music issues #22

Closed francisdb closed 1 year ago

francisdb commented 1 year ago

Something is messed up with the fluorescent plastic rendering and with the dmd ()

This is what I see

image

image

This is what you see with standard vpx

image
francisdb commented 1 year ago

One more issue, the soundtrack I bought is not playing. You mentioned you do path fixing in the music player. However the script does a fso.FolderExists which returns false. So to get music on mac you need this patch

--- /Users/francisdb/vpinball/tables/Total Nuclear Annihilation (Spooky 2017) VPW v2.2/Total Nuclear Annihilation (Spooky 2017) VPW v2.2.vbs.original.tmp   2023-06-12 15:27:15
+++ /Users/francisdb/vpinball/tables/Total Nuclear Annihilation (Spooky 2017) VPW v2.2/Total Nuclear Annihilation (Spooky 2017) VPW v2.2.vbs    2023-06-12 15:27:12
@@ -64,8 +64,8 @@
 ' \Visual Pinball\Music\TNA
 ' then you must set bMusicOn to True in the script:

-Const  Disable_TNA_Message     = False     'True - to disable the TNA pop-up message.  False = display TNA pop-up message
-Const  bMusicOn                = False     'True = enable, False = disable TNA original music
+Const  Disable_TNA_Message     = True      'True - to disable the TNA pop-up message.  False = display TNA pop-up message
+Const  bMusicOn                = True      'True = enable, False = disable TNA original music
 Const  bMusicVolume            = 0.7       'A volume multiplier for the game's music (Applicable only if bMusicOn=true)

 ' Please show Scott Danesi your support and thanks for creating an awesome pinball game and for making the music available for us to buy.
@@ -1484,9 +1484,9 @@
 sub InitMusicFolder
    Dim fso
    Set fso = CreateObject("Scripting.FileSystemObject")
-   if Not fso.FolderExists(MusicDirectory & "\" & MusicSubDirectory) Then
-       MusicSubDirectory = ""
-   end if
+   ' if Not fso.FolderExists(MusicDirectory & "\" & MusicSubDirectory) Then
+   '   MusicSubDirectory = ""
+   ' end if
    set fso = nothing
 end sub
francisdb commented 1 year ago

Just tried latest VPinballX_GL64.exe

Fluo plastics look correct DMD also has the grey pixels showing. Even using latest VPinballX64.exe.

So only the plastics issue is standalone related.

francisdb commented 1 year ago

Forget about the DMD part, only the plastics issue remains

francisdb commented 1 year ago

image

francisdb commented 1 year ago

This Acrylics [Wall](11)

image
francisdb commented 1 year ago

Big bang bar has similar neon plastics

jsm174 commented 1 year ago

I spent some time running this under Windows and Linux to get Renderdoc frame captures.

This is pretty much out of my domain, but it appears that in standalone, GL_BLEND is disabled where as in windows it is not.

Screenshot_2023-06-17_at_5 55 25_PM

I've let @vbousquet know, so hopefully he might have some more insights.

francisdb commented 1 year ago

Do we want to move this over to the vpinball repo then?

jsm174 commented 1 year ago

If you want to, that would be great. I do have RDC captures if needed.

francisdb commented 1 year ago

I don't think I can move this issue. Maybe you can?

jsm174 commented 1 year ago

Turns out this was a long standing issue that I never noticed.

GetMaterial is one of the few VPX COM functions that have [out] parameters. I did not have this coded correctly, so any tables that call GetMaterial would just get empty values, thus causing strange results.

This now renders fine in standalone:

Screenshot 2023-07-20 at 5 08 09 PM