search

jsm174 / vpx-standalone-scripts

Table patches for VPX Standalone
https://github.com/vpinball/vpinball/tree/standalone/
35 stars 15 forks source link

[Script Error] patch: Wheel of Fortune (Stern 2007) 1.0 #247

Closed zognic closed 9 months ago

zognic commented 10 months ago

There is still a script issue with this table https://github.com/jsm174/vpx-standalone-scripts/pull/77

ERROR [3487] [CodeViewer::OnScriptError@1180] Script Error at line 584 : VBSE_OUT_OF_BOUNDS

Sub LampTimer_Timer()
    Dim chgLamp, num, chg, ii
    chgLamp = Controller.ChangedLamps
    If Not IsEmpty(chgLamp) Then
        For ii = 0 To UBound(chgLamp)
            LampState(chgLamp(ii, 0) ) = chgLamp(ii, 1)       'keep the real state in an array
            FadingLevel(chgLamp(ii, 0) ) = chgLamp(ii, 1) + 4 'actual fading step
        Next
    End If
    UpdateLamps
End Sub

lines 584 & 585

             LampState(chgLamp(ii, 0) ) = chgLamp(ii, 1)       'keep the real state in an array
             FadingLevel(chgLamp(ii, 0) ) = chgLamp(ii, 1) + 4 'actual fading step
francisdb commented 10 months ago

At a first glance this might have something to do with the recent pinmame pwm changes.

francisdb commented 10 months ago

@zognic how do I reproduce this error?

I seem to have other strange issues where flippers don't react or are stuck.

francisdb commented 10 months ago

What vpinball version are you using?

zognic commented 10 months ago

are

Visual Pinball v10.8.0 Beta (Rev. 1880 (c4e2ac8), linux OpenGL 64bits) I fixed the issue by removing theses lines

francisdb commented 10 months ago

Aha yes now this rings a bell, I previously reported this on pinmame https://github.com/vpinball/pinmame/issues/196

Let me submit my current patch