search

jsm174 / vpx-standalone-scripts

Table patches for VPX Standalone
https://github.com/vpinball/vpinball/tree/standalone/
34 stars 15 forks source link

fix startup crash #309

Open m-i-k-e-e opened 5 months ago

m-i-k-e-e commented 5 months ago

assuming int as boolean was not working

francisdb commented 5 months ago

https://www.vpforums.org/index.php?app=downloads&showfile=16086

jsm174 commented 5 months ago

@francisdb - have we seen this issue before? I thought people do checks like this all the time.

@m-i-k-e-e - This looks wrong, no space between the 0 and Then

Screenshot 2024-06-11 at 7 37 17 AM

francisdb commented 5 months ago

vpmColourised is actually "" and vbscript does not support If "" Then. Values like "0" or "true" work

Controller.Games(cGameName).Settings.Value("dmd_colorize") on windows returns 0 because vpinmame comes with some default settings

Not sure I picked the correct locations but pretty sure these are set up by default

https://github.com/vpinball/pinmame/blob/7bb409ec08cf9e4221a1463f58defcfb4e558437/src/win32com/VPinMAMEConfig.cpp#L81-L91

https://github.com/vpinball/pinmame/blob/7bb409ec08cf9e4221a1463f58defcfb4e558437/src/unix/config.c#L78-L87

@jsm174 is this something you would want to add to standalone?

francisdb commented 5 months ago

@m-i-k-e-e a rebase should fix the build checks, but not a big deal as this was a known issue

francisdb commented 5 months ago

I wonder if all the other recent bigus tables have this issue.