jsme-editor / jsme-editor.github.io

73 stars 19 forks source link

Problems with coloring functional group page #48

Open pquagliotto opened 2 months ago

pquagliotto commented 2 months ago

Dear programmers,

I have just found a problem in the functional groups colouring poage:

https://jsme-editor.github.io/dist/JSME_functional_group_coloring.html

When colouring the different functional groups, in the case of the amine group of the proposed case (glutathione), the NH2 group is coloured but instead of the NH2, only the number 2 is displayed. This does not affect the final results as an answer but could be puzzling for students who are trying to give answers to proposed questions.

Is this coming from a set up of the page, or form a bad interaction of internal JSME programmed functions (i.e something which should be corrected at the programming level)?

We would implement something similar on our site but it shoudl be better to know about possibile failures of the system before implementing it.

Best regards ,

Pierluigi

pquagliotto commented 2 months ago

I can still add that this is occurring only with NH2 group. If wee have R'-NH-R the behaviour is ok.

The problem is reproducible on Chrome, Safari and Firefox on both Mac and Windows.

Best regards,

Pierluigi

jsme-editor commented 2 months ago

This issue was fixed in version 2024-04-29.

pquagliotto commented 2 months ago

dear all,

many thanks for the fast correction! I will check it immediately.

best regards,

Pierluigi Quagliotto

Prof. Pierluigi Quagliotto Professore Associato di Chimica Organica (SSD: CHIM 06)

Università degli Studi di Torino Dipartimento di Chimica Via Pietro Giuria 7 10125 Torino (Italia)

Tel: 011-6707593 https://www.chimica.unito.it https://www.iorgchem.unito.it

Il giorno lun 13 mag 2024 alle ore 13:09 jsme-editor < @.***> ha scritto:

This issue was fixed in version 2024-04-29.

— Reply to this email directly, view it on GitHub https://github.com/jsme-editor/jsme-editor.github.io/issues/48#issuecomment-2107290565, or unsubscribe https://github.com/notifications/unsubscribe-auth/BH6ECHDSGYQO45FJ5VLU7GTZCCNNRAVCNFSM6AAAAABGO6IZNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGI4TANJWGU . You are receiving this because you authored the thread.Message ID: @.***>