Initial work on platform-specific keybindings

sogaiu commented 5 years ago

Please consider platform-specific keybindings, given the use of the command key in the existing bindings. Thanks :)

aravindet commented 5 years ago

Ctrl+C is commonly used to exit command-line applications (such as watch-mode build/test scripts) and should not be trapped in terminal. I suggest Ctrl+Shift+C as the alternative (this is the default in gnome-terminal and probably many other terminals in Linux-land).
For consistency, it should be Ctrl+Shift-V for paste.
Several command-line applications might also use Ctrl+K, Ctrl+W etc. For example the popular command line editor nano by default uses Ctrl+K for cut line and Ctrl+W for find. Why would you run a text editor in a terminal in another text editor? Because (for example) git might open it for editing commit messages, interactive rebase, etc. I suggest that they should also be Ctrl+Shift+K and Ctrl+Shift+W.
I agree with Ctrl+Shift+T for opening the terminal, as it avoids conflicting with Ctrl+T for the fuzzy finder. (Although Ctrl+P also opens the fuzzy finder.)

sogaiu commented 5 years ago

I agree that the suggestions (additional Shift modifier for the 5 items) make more sense than what is in the original PR.

@aravindet, perhaps I should just close this PR and you can open a different one instead?

aravindet commented 5 years ago

Thanks sogaiu! Please don't close your PR, you can push an update on it.

Thanks, Aravind

On Fri, Feb 22, 2019 at 11:35 AM sogaiu notifications@github.com wrote:

I agree that the suggestions (additional Shift modifier for the 5 items) make more sense than what is in the original PR.

@aravindet https://github.com/aravindet, perhaps I should just close this PR and you can open a different one instead?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jsmecham/atom-terminal-tab/pull/105#issuecomment-466261663, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM2F15Led3dWV0Cq_K4UalhGHrmUmMDks5vP2V6gaJpZM4ahGi8 .

sogaiu commented 5 years ago

Updated as requested. Hope that works.

jsmecham / atom-terminal-tab

Initial work on platform-specific keybindings #105