search

jsmecham / atom-terminal-tab

Simple terminal for the Atom text editor.
https://atom.io/packages/terminal-tab
MIT License
142 stars 29 forks source link

Customize TERM variable option #128

Open BDMorrell opened 4 years ago

BDMorrell commented 4 years ago

Can we have a way to declare which terminal we're using?

Most of my terminal colors don't work with the default xterm-color, and it seems that xterm-256color is supported by this addon:

this seems like a hack to me

I'm using

Thank you! Great addon, by the way!

jsmecham commented 4 years ago

Curious if there's any harm in just defaulting to xterm-256color? I'd like to avoid adding options and settings, if possible, as my goal for this addon is to work out of the box for most people without thinking about configuration.

BDMorrell commented 4 years ago

Doing some research, it seems that TERM=xterm-256color should be okay. I haven't found anything that would say otherwise.

While we're at it, why not set COLORTERM=truecolor? I would say it's supported because of xtermjs/xterm.js#1895.

I also found an article about terminal colors.

I don't quite know how to set these variables accurately, but it seems that it would have to do with lib/terminal-session: https://github.com/jsmecham/atom-terminal-tab/blob/d608f7166586a9d8bffe98007b37118e8040e27b/lib/terminal-session.js#L45-L49