jsmits / zwift-client

Zwift Mobile API client written in Python.
MIT License
55 stars 20 forks source link

Lock down protobuf version or recompile distribution files on build #377

Open tylerwmarrs opened 1 year ago

tylerwmarrs commented 1 year ago

Description

The compiled protobuf files are not compatible with the requirements in the setup.py Changing the version to "protobuf<=3.21.0" resolves the import issue. You may either recompile the protobuf files distributed on build or lock down protobuf version.

What I Did

from zwift import Client as ZwiftClient
snicker commented 1 year ago

downstream consumers can apply the workaround proposed in a method similar to https://github.com/snicker/zwift_hass/pull/38

snicker commented 1 year ago

not sure if @jsmits is still maintaining this library but the best solution is going to require regenerating the pb2 file with a new version of protoc, bumping the release, and redeploying to PyPI