search

jsmitty12 / phpWhois

phpWhois general repository
GNU General Public License v2.0
56 stars 20 forks source link

Added support for .dk domains #28

Closed TorbenLundsgaard closed 6 years ago

jsmitty12 commented 6 years ago

Thanks for the PR--this is going to be a great addition to phpWhoIs!

I have two requests:

  1. One of my long-term goals for the project is to update the code to follow the PSR-12 coding style. Will you update the whois.dk.php file to follow PSR-12? (I think simply adding braces to the if statements on lines 25 and 45, and then moving the braces from the ends of lines 30 and 32 to the next lines will do it.)
  2. Another long-term goal is to create PHPUnit tests for the system (leveraging fixtures to ensure that the tests are always fast). Will you add one or more tests for .dk domains following the pattern started in the /tests directory?

Please let me know if you have any questions, and thanks again for your contribution!

TorbenLundsgaard commented 6 years ago

I have fixed the code style and will write a test

TorbenLundsgaard commented 6 years ago

@jsmitty12 I have no idea why the test i failing. Can you help?

jsmitty12 commented 6 years ago

Yep... I'm looking at it now

jsmitty12 commented 6 years ago

I don't know what error you're getting, but initially I got Error : Class 'dk_handler' not found. To fix that, simply run composer dump-autoload.

@TorbenLundsgaard Does that happen to be the error you are getting?

TorbenLundsgaard commented 6 years ago

@jsmitty12 I fixed the problem and Travis is happy. However, there is a problem with Scrutinizer but it doesn't seem to be related to my code.

jsmitty12 commented 6 years ago

Don't worry about Scrutinizer--setting that up is still a work in progress. Thanks for your quick response today, @TorbenLundsgaard ! I'll try to get this reviewed and merged over the weekend.