search

jsmitty12 / phpWhois

phpWhois general repository
GNU General Public License v2.0
56 stars 20 forks source link

each() replacement is incorrect #7

Closed jsmitty12 closed 6 years ago

jsmitty12 commented 6 years ago

PHP 7.2 deprecated the each() function. One suggested replacement is a simple foreach(), but it cannot be done blindly. Unfortunately, the initial removal of the each() function was a blind foreach() replacement.

jsmitty12 commented 6 years ago

Two broken replacements were fixed previously (Thank you @adamjimenez!). I examined each remaining foreach() replacement and I have concluded that they are all fine and can remain as they are.