search

jsmmth / vue-loop

Infinite content loop for Vue
820 stars 37 forks source link

Does not work on Firefox #9

Closed jdegger closed 7 years ago

jdegger commented 7 years ago

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0

No errors in the console

jsmmth commented 7 years ago

@jdegger I am currently working on some big improvements to mobile support, but this will be included too. Although I can't replicate the issue, would you mind being more specific with whats not working exactly, cause the looped scroll seems to work for me?

jdegger commented 7 years ago

Well, I'm not sure how to explain it better than 'it does not work'. I made a screencast for you so you can see it just works as normal static page without the infinite scrolling:

https://www.youtube.com/watch?v=0wB3N4jmvKA&feature=youtu.be

jsmmth commented 7 years ago

hmmmm. Am I missing something? https://www.dropbox.com/s/do586bks8nl4nmr/working%3F.mov?dl=0

jdegger commented 7 years ago

Restarting Firefox fixed the issue. No clue why, I even tried disabling some addons but just the restart seems sufficient.

Closing the issue :) nice work btw!

qgustavor commented 7 years ago

I think I have the same issue: scrolling with the scroll wheel or with the keyboard don't works until the page is resized. I don't know why, but it works if I scroll with mid button click or dragging the scroll bar.

I think the problem is that getDimensions get called before the cloned element gets included, so it's not counted in the pageHeight calculation, which makes scrollHandler behave as the page ended just before the cloned element. Resizing the page makes getDimensions run again, updating pageHeight to the correct value.