search

jsmrcaga / action-netlify-deploy

MIT License
104 stars 32 forks source link

Added the crisperit/action-netlify-deploy docker image #41

Closed crisperit closed 1 year ago

crisperit commented 1 year ago

@jsmrcaga Here is mine idea for the optimization

I've created and pushed to Docker Hub the image optimized for that action https://hub.docker.com/repository/docker/crisperit/action-netlify-deploy

(You can even think of installing multiple node versions ahead in this image - and on action runtime just switch node versions instead of installing them)

The Netlify deploy with that action took 33 sec

Previously it was taking 2 minutes..

Fixes #35

jsmrcaga commented 1 year ago

Hi @crisperit ! Thanks a lot for the pull request 🚀

The time difference is astonishing, this will save a lot of money for a lot of people if they are paying GitHub action minutes ^^

I was wondering though, have you tried to run the action with no docker at all? Since netlify-cli is pre-installed on GitHub runners, I'm guessing we can modify the bash script to read the inputs directly from the environment (using $INPUT_xxxx) and it would just... work? Im not sure. The action would change from Docker to composite

Then people could just use actions/setup-node if they need a custom node version and we could get rid of our custom node/nvm implementation.

What are your thoughts? Do you think you could give it a try?

crisperit commented 1 year ago

Ok, I'll try

crisperit commented 1 year ago

Closing as https://github.com/jsmrcaga/action-netlify-deploy/pull/42 solves the same problem and look better