jsmrcaga / action-netlify-deploy

MIT License
104 stars 32 forks source link

feat: Switching the action from docker into composite #42

Closed crisperit closed 1 year ago

crisperit commented 1 year ago

@jsmrcaga Here is the another approach - to use already installed netlify-cli

The time difference is pretty the same as with the prepared specially docker image - but it might be easier to maintain that's why I like that version more

I've tested that action only with a scenario of not having to run nvm, install step or build step

@jsmrcaga You can try to test it more

Fixes https://github.com/jsmrcaga/action-netlify-deploy/issues/35

crisperit commented 1 year ago

Hi @crisperit , I'm so sorry this is taking so long, I'm caught up in different projects. Your PR looks good! I was thinking that it was not necessary to completely remove the entrypoint.sh file though, you could just leave it as is and call it via the composite action if I'm not mistaken. It would make for a way simpler action.yml file and much less diff in the pull request ;) it would also allow to make the .sh file "testable" if we ever decide/need to add unit testing

Done - I've returned entrypoint.sh

jsmrcaga commented 1 year ago

@crisperit looks amazing! Sorry again for the delay! There is some auto-formatting but since there are so many changes anyway it's ok 😉

I'm gonna go ahead and release a major version, thanks a lot for all the work you put in! If you'd like you can add your name to the README as well in another PR