search

jsmreese / moment-duration-format

Format function plugin for the Moment Duration object.
MIT License
969 stars 120 forks source link

formatNumber localization options should be moved into this plugin's Moment Locale API extensions #99

Open jsmreese opened 6 years ago

jsmreese commented 6 years ago

This plugin already requires extending the Moment Locale object for duration label localization. Number format localization options should be moved into that object as well.

Version 2 number localization uses three options: grouping, decimalSeparator, and groupingSeparator. Those should be removed from the plugin API, or (perhaps less desirable), the duration label localization options should be added to the plugin API.

The formatNumber function should accept a locale string for localization, just as Number#toLocaleString does.