Remove global variable mutation

jsnanigans / vue-parallax-js

Tiny vue component that adds a directive for parallax effect on elements.

120 stars 19 forks source link

Closed Neo-Zhixing closed 4 years ago

Neo-Zhixing commented 5 years ago

The original package mutated "window" and "document" global variables to null when they're undefined. This caused a problem with Vuex and Nuxt.js.

jsnanigans commented 4 years ago

Thank you for your PR and sorry it took me so long

Neo-Zhixing commented 4 years ago

Haha it certainly took a bit