search

jsnyder / arm-eabi-toolchain

Makefile & supporting patches/scripts to build a bare metal ARM EABI toolchain.
264 stars 67 forks source link

2012.03-56 new Sourcery URLs #23

Open ilg-ul opened 12 years ago

ilg-ul commented 12 years ago

Although it seems that Mentor maintains the old download URLs, as far as I could see, the new URLs are slightly changed:

https://sourcery.mentor.com/GNUToolchain/package10384/public/arm-none-eabi/arm-2012.03-56-arm-none-eabi.src.tar.bz2 https://sourcery.mentor.com/GNUToolchain/package10385/public/arm-none-eabi/arm-2012.03-56-arm-none-eabi-i686-pc-linux-gnu.tar.bz2

Perhaps it would be necesary to update the URLs to reflect this.

I would also suggest to use '?=' instead of '=' for the lines 56-62, to allow URL customisation.

Regards,

Liviu

bradtgmurray commented 12 years ago

The way I prefer to customize makefiles is by specifying the extra arguments on the command line. Command line variable assignments always override variable assignments in the makefile itself, regardless of '?=' vs '='.

ilg-ul commented 12 years ago

Ok, that's a solution, however the structure of the script I use to call the Makefile is a bit more complex and passing these values via environment variables is probably more appropriate.

I think that adding the '?' in the Makefile is easier than having my script define and apply patches to the Makefile, as I had to do with previous versions.