search

jso-docs / tutorial-template

Template for pages for jso-docs
https://jso-docs.github.io/contributing
Mozilla Public License 2.0
2 stars 0 forks source link

getdeps.sh CRLF issue #2

Open AntoninKns opened 2 years ago

AntoninKns commented 2 years ago

Thanks @abelsiqueira for the very well done tutorial !

There seems to be a minor issue with the format of the getdeps.sh

When I initially ran it there was a CRLF problem with the line :

'wget https://github.com/jso-docs/jso-docs.github.io/archive/refs/heads/main.zip'

The link was interpreted as 'https://github.com/jso-docs/jso-docs.github.io/archive/refs/heads/main.zip%0D' due to a problem of compatbility for end of line between linux and windows.

Of course it is possible to launch the command by hand by writing the content of the file in a shell so it is not a big problem. One way of fixing it for me was to use the 'dos2unix' command and then it worked perfectly.

Don't hesitate to let me know if you need more details on how I encoutered this error.

abelsiqueira commented 2 years ago

Hi @AntoninKns, thanks for the report. Since it is a Windows issue, there is not much I can do to fix it because I don't use Windows. Have you used it from WSL? If you see a way of fixing it without breaking it for Linux I would be happy to receive a pull request.