search

jsocol / django-adminplus

Easily add custom views to the Django admin.
BSD 3-Clause "New" or "Revised" License
591 stars 79 forks source link

Django 4 support #64

Closed ivorbosloper closed 11 months ago

ivorbosloper commented 2 years ago

Django 4 breaks with Exception:

 File "adminplus/sites.py", line 47, in get_urls
    from django.conf.urls import url
ImportError: cannot import name 'url' from 'django.conf.urls' (django/conf/urls/__init__.py)

The cause is; django.conf.urls.url() was deprecated since Django 3.1, is removed in Django 4.0+. It can be resolved by using path or re_path , see docs.

cchacholiades commented 2 years ago

Any plans on releasing this?

CircuitCipher commented 2 years ago

@cchacholiades I don't know why I keep running into this situation. I'm building my first for production Django website and keep seeing projects like this recommended only to find they haven't been touched in years and don't do anything with pull requests that fix support for the latest Django. Is the Django community dead or something or is it a bunch of people that used it from 10 years ago and are just content running django 2 on their already completed website?

@jsocol Anything we can do to help get this merged?

artemdou commented 2 years ago

Hey! Any plans to merge the pr?

ivorbosloper commented 1 year ago

Fixed with merge...

merwok commented 1 year ago

It’s merged in a fork, not in this repo

helissonomc commented 11 months ago

It’s merged in a fork, not in this repo

where is this merged? i am trying to use the .5 version and it is not there

jsocol commented 11 months ago

I'm working on getting a new release cut. I believe this will be the last 0.x release

helissonomc commented 11 months ago

I'm working on getting a new release cut. I believe this will be the last 0.x release

Nice! Thank you!

jsocol commented 11 months ago

It's out! https://pypi.org/project/django-adminplus/0.6/

Please file issues if you encounter anything with various versions of Django. I fully expect there to be issues given there hasn't been a release in ~8 years 😅