search

jsoftware / jsource

J engine source mirror
Other
645 stars 91 forks source link

Openbsd arm64 and amd64 support #111

Closed AshyIsMe closed 1 year ago

AshyIsMe commented 2 years ago

Recently Brian Callahan made a J port for OpenBSD amd64: https://briancallahan.net/blog/20210911.html The details of his port patches are here: https://marc.info/?l=openbsd-ports&m=163138993214367&w=2

I thought it would be nice for the main J repo to build on OpenBSD out of the box without patches required. This has been tested on an Intel i7-1165G7 laptop (Lemur Pro lemp10) and a Raspberry Pi 4 8GB both running OpenBSD 7.0 (CURRENT snapshots).

As mentioned in the commit messages a fair few of the tsu.ijs tests succeed but both architectures crash during or just after g128x7.ijs. Brian Callahan mentions in his post that the gss.ijs test fails for him with his port.

I've attempted to follow the existing code style in the build scripts even though there's a little bit of repetition. Are there any changes or cleanup required to get this merged?

eiverson commented 2 years ago

We would like to pick up these changes and improve/simplify Jsoftware support for BSD. RIght now we don't have the resources to vet this properly and to finish off the current edges. We hope to have someone before year end who will be responsible for exactly these kinds of pull requests. This will be announced when we are ready.

Thanks for your contributions and also to Brian Callahan. We'll try to get them included by year end and then should be in a position to more easily stay current with contributions.

On Sat, Oct 9, 2021 at 9:06 PM Aaron Ash @.***> wrote:

Recently Brian Callahan made a J port for OpenBSD amd64: https://briancallahan.net/blog/20210911.html The details of his port patches are here: https://marc.info/?l=openbsd-ports&m=163138993214367&w=2

I thought it would be nice for the main J repo to build on OpenBSD out of the box without patches required. This has been tested on an Intel i7-1165G7 laptop (Lemur Pro lemp10) and a Raspberry Pi 4 8GB both running OpenBSD 7.0 (CURRENT snapshots).

As mentioned in the commit messages a fair few of the tsu.ijs tests succeed but both architectures crash during or just after g128x7.ijs. Brian Callahan mentions in his post that the gss.ijs test fails for him with his port.

I've attempted to follow the existing code style in the build scripts even though there's a little bit of repetition. Are there any changes or cleanup required to get this merged?

You can view, comment on, or merge this pull request online at:

https://github.com/jsoftware/jsource/pull/111 Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jsoftware/jsource/pull/111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBRCHW2XOWIY2MW4NHAR43UGDRKTANCNFSM5FV36MJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

AshyIsMe commented 2 years ago

Thanks @eiverson, in the mean time I'll try to narrow down the failing tests.

AshyIsMe commented 2 years ago

Rebased onto the latest jsource master branch and tested successfully again on openbsd x86_64 (intel i7-1165G7) and arm64 (rpi4).

bilam commented 1 year ago

openbsd for amd64 and arm64 should work and run test suite clean now.