search

jsoma / playfair-projects

Common repository of projects for Playfair
6 stars 32 forks source link

NBA salary charts [Assistance Request] #2

Closed jsoma closed 8 years ago

jsoma commented 8 years ago

Approved from Pitch #1

I'll be building several static scatterplot visualizations about player performance in the NBA (pandas + Illustrator). I'll see how it looks with points along with a few other statistics - blocks, turnovers, etc. Will look kind of like a nicer version of this:

screen shot 2016-07-21 at 4 26 08 pm

Data sets:

If anyone wants to help out let me know, I think there are some crazy math-y things we could do with the stats that I don't quite get.

Tips for the story part:

  • Be sure to mention your pitch in the first line - by typing a "#" it will automatically provide you with a list of issues you can link to. My original pitch was at https://github.com/jsoma/playfair_projects/issues/1, so I can type #1 to automatically link to my pitch.
  • Now that you're approved, you can go hunting for people to help you out
jsoma commented 8 years ago

In theory I would reference this in a pull request, but I don't really feel like doing that now, so I'll just pretend it did.

jsoma commented 8 years ago

Here's a work-in-progress update! I'd love to hear what people think.

image

Tips for story updates:

  • Nothing's secret! Keep everyone informed of what's going on, they might have subscribed to this issue because they're so excited.
  • You can also link to content in your forked version of the repository.
jsoma commented 8 years ago

Oh that's looking great, the colors are really fun! But I wish I knew a little more about Stephen Curry and DeMarcus Cousins - I'd love a little more imagery on the page to help me connect with it emotionally.

Tips for providing feedback:

  • Again, we're all human! Be nice! Be very nice!
  • It's totally possible someone did something terribly wrong. Definitely point those things out, but definitely point them out in a way that makes the person want to change them - being aggressive only makes people defensive.
jsoma commented 8 years ago

This might be my last version! I added some images based on some suggestions and I think it turned out pretty nice.

image

jsoma commented 8 years ago

Looks good! I'll tag this so that an editor will come along and take a look.

jsoma commented 8 years ago

I dig it, submit a pull request and I'll approve it.

jsoma commented 8 years ago

Just pretend I submitted a pull request

jsoma commented 8 years ago

Done and done!

jsoma commented 8 years ago

Story issue checklist

My pitch was (use the number): #1