search

json-api-php / json-api

Implementation of JSON API in PHP
https://json-api-php.github.io/
MIT License
183 stars 18 forks source link

MetaDocumentMember should be Attachable #87

Closed OndraM closed 6 years ago

OndraM commented 6 years ago

Hi, if I'm not mistaken, MetaDocumentMember should implement Attachable interface.

MetaDocument accepts MetaDocumentMember as a second (variadic) argument of its constructor. It then calls combine() function an pass it the MetaDocumentMembers. But the combine() requires its parameters to be attachable, as it calls attachTo() method on them.

f3ath commented 6 years ago

Good catch. Thanks.