search

json-api-php / json-api

Implementation of JSON API in PHP
https://json-api-php.github.io/
MIT License
183 stars 18 forks source link

PHP 7.1 support #89

Closed franzliedke closed 5 years ago

franzliedke commented 5 years ago

Do you need PHP 7.2 support in v2 of this library? You seem to be using the new object typehint in some places, but I guess (hope) that's not life-critical. Is there anything else? Anything you wouldn't want to miss?

I am asking because we are considering using this library for Flarum (transitively through tobscure/json-api-server), and we want to keep supporting PHP 7.1 for a while.

f3ath commented 5 years ago

Sure we can downgrade to 7.1. Feel free to open a PR.

f3ath commented 5 years ago

Downgraded to 7.1 https://packagist.org/packages/json-api-php/json-api

franzliedke commented 5 years ago

Very cool, thanks for the quick reaction! And a happy new year to you! :fireworks: