C-c P is not a well-defined mode-specific keybinding

json-emacs / json-mode

Major mode for editing JSON files with emacs

314 stars 66 forks source link

C-c P is not a well-defined mode-specific keybinding #66

Closed UwUnyaa closed 1 year ago

UwUnyaa commented 4 years ago

https://github.com/joshwnj/json-mode/blob/0e819e519ae17a2686e0881c4ca51fa873fa9b83/json-mode.el#L140

This command is bound to C-c P, which is a C-c letter keybinding, reserved for user customization. It should be replaced with some other binding, such as C-c C-w, which doesn't seem to be used by the parent mode. I can submit a patch, but deciding on what keybinding makes sense first is the more productive way to accomplish this.

UwUnyaa commented 4 years ago

I forgot to link the relevant section of the elisp manual: https://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html#Key-Binding-Conventions

taku0 commented 1 year ago

Fixed via #70.