search

json-iterator / java

jsoniter (json-iterator) is fast and flexible JSON parser available in Java and Go
http://jsoniter.com/
MIT License
1.51k stars 518 forks source link

Adding encoding as parameter to methods deserialize and serialize #253

Open leocampos opened 4 years ago

leocampos commented 4 years ago

This pull request tries to address the issue https://github.com/json-iterator/java/issues/229

Especially with so many managed services on the Cloud, some of which we do not have any control over the initialization of the JVM, it is important to be able to control the encoding used by the library. I faced recently the problem of having one of these managed services in US-ASCII, but our Strings were encoded with UTF-8. All special characters were transformed to "?".

TheNeuralBit commented 4 years ago

@taowen is there any chance this could get merged? it's fixing a pretty big issue

leocampos commented 4 years ago

BTW, we are mostly starting to migrate to another JSON parser in which the development is more active.

pradeepcheers commented 3 years ago

@leocampos what's the name of the new JSON parser that you mentioned the development is active

leocampos commented 3 years ago

@pradeepcheers We are currently using Jackson. https://github.com/FasterXML/jackson.

The approach we took, though, was to wrap it around a class of ours, so we can later choose the library and change it in a single place.

Brixomatic commented 2 years ago

For UTF-16 this PR crashes with:

com.jsoniter.spi.JsonException: read: premature end, head: 1, peek: �, buf: �� { " n a m e " : " T h o m a s  M � l l e r " }
    at com.jsoniter/com.jsoniter.JsonIterator.reportError(JsonIterator.java:143)
    at com.jsoniter/com.jsoniter.JsonIterator.readAny(JsonIterator.java:272)
    at com.jsoniter/com.jsoniter.JsonIterator.deserialize(JsonIterator.java:522)
    at com.jsoniter/com.jsoniter.JsonIterator.deserialize(JsonIterator.java:505)
    at com.jsoniter/com.jsoniter.TestString.test_encoding_different_than_default(TestString.java:41)

Also the test does not work for Java 17 modules as reflective access to Charset.defaultCharset is prohibited.