search

json-ld / json-ld.org

JSON for Linked Data's documentation and playground site
https://json-ld.org/
Other
853 stars 152 forks source link

Updated playground breaks spec examples #693

Closed gkellogg closed 4 years ago

gkellogg commented 5 years ago

Changing the default playground to 1.1 is fine, but removing /playground-dev brakes the specs, which use this in the "Open in playground" link. We should redirect this to /playground (without loosing the query args). The specs can be updated, but not the already-published working drafts.

davidlehn commented 5 years ago

I did add a redirect for that purpose. I think it was just a typo that I somehow missed while testing. Does this fix work? https://github.com/json-ld/json-ld.org/commit/ec3882958a9d87a273dd0b959d55c284aa1647a8

gkellogg commented 5 years ago

Not loading for me; try one of the examples from the spec.

BigBlueHat commented 5 years ago

Good to know this is going on. I came to file a redirect bug issue. 😄 Partly because the message is still above the playground which states there's a dev playground I can use...which sends me back to where I was... 😕 Might want to at least remove the message.

BigBlueHat commented 5 years ago

Also, not sure this is actually working...the @nest example from the spec (at least) isn't currently working: example 71

davidlehn commented 5 years ago

Is there some strange caching going on here? Check network traffic and see if new pages are actually fetched. Or just try a force reload. Everything loads for me. There are no links to the former playground-dev page on the site. Links to former dev page should redirect to main page and still work.

@BigBlueHat Are you saying the @nest example output is wrong or it just doesn't load at all?

BigBlueHat commented 5 years ago

Yep. It's caching. A "shift + refresh" did the trick...but folks won't know to do that. 😢

Thoughts? 💭

gkellogg commented 5 years ago

One way to avoid this is to use some randomized string as a query to the URLs for the various resources. Asset packages I use with Ruby handle this automatically.

BigBlueHat commented 5 years ago

In this case it's not the sub-resources/dependencies being aggressively cashed, but the page itself--hence the visibility of the notice about their being a dev playground. That URL can't be updated ('cause it's linked all the places), so this is probably something unfixable and we can only wait for Expires headers (or whatever caused this) to expire.

But someone with server config access would have to inform what's actually causing the caching issue...which could even be a fronting proxy of some kind...

Yeah Webz! 🕸

davidlehn commented 5 years ago

It's just apache. Looks like it just sends etag and last modified date. Those usually work ok. I don't have the issue so it's hard to debug it.

gkellogg commented 4 years ago

Fixed now.