search

json-ld / yaml-ld

CG specification for YAML-LD and UCR
https://json-ld.github.io/yaml-ld/spec
Other
22 stars 8 forks source link

Update examples #53

Closed gkellogg closed 2 years ago

gkellogg commented 2 years ago

cc/ @anatoly-scherbakov

Preview | Diff

ioggstream commented 2 years ago

Gregg, I'll fix this PR on Sunday :)

anatoly-scherbakov commented 2 years ago

Just for my understanding: I have looked through the code and the preview, everything looks very good; if something else must be done for this perhaps I can be of asistance?

gkellogg commented 2 years ago

Just for my understanding: I have looked through the code and the preview, everything looks very good; if something else must be done for this perhaps I can be of asistance?

I think there's possibly something @ioggstream wants changed that isn't strictly related to the new markup.

Eventually, I'll port over https://github.com/w3c/json-ld-wg/blob/main/common/extract-examples.rb which checks the examples for correctness as part of CI. Also, we may want to use some tabbed examples and link to the playground, as is done in the 1.1 specs; of course, that will require an update to jsonld.js or some shim.

Of course, anything you think would be useful or some alternative mechanisms are fair game, and we can discuss offline.

anatoly-scherbakov commented 2 years ago

Thanks! At this point I am not well versed enough with W3C tooling to make useful suggestions; looking forward to better educate myself on this while taking part in this activity.