json-schema-form / angular-schema-form

Generate forms from a JSON schema, with AngularJS!
https://json-schema-form.github.io/angular-schema-form
MIT License
2.47k stars 653 forks source link

Model inside Array is not cleaned when Condition fails #769

Closed doomie999 closed 7 years ago

doomie999 commented 8 years ago

Expected behaviour

Plunker of the bug The Array contains Objects with several properties:

Upon filling in helloText, fooText, barText, note that:

I've coded up a small fix for this, and will be adding a Pull Request subsequently.

@json-schema-form/angular-schema-form-lead

Anthropic commented 8 years ago

@doomie999 we love PRs, so thank you for your efforts, I will continue to follow the PR so we can get it merged :)

Anthropic commented 7 years ago

Made a gist link to test locally and want to remember it: http://schemaform.io/examples/bootstrap-example.html#/f7078098dc03151c5a0cc18c6452aaea

Anthropic commented 7 years ago

@doomie999 pleased to say this appears to be working in alpha.4 after some other remotely related changes to fix array behaviour. I have tested at depth yet, but I don't see why it wouldn't work, I will try to create a unit test at depth soon.