sf-field tests, and minor changes to karma.conf

json-schema-form / angular-schema-form

Generate forms from a JSON schema, with AngularJS!

https://json-schema-form.github.io/angular-schema-form

MIT License

2.47k stars 653 forks source link

sf-field tests, and minor changes to karma.conf #873

Closed mnzaki closed 7 years ago

mnzaki commented 7 years ago

Description

sf-field tests for issue #870 Use mocha reporter in karma, for proper expected-actual diff output Remove duplicate tests from sf-schema

Checklist

[x] I have read and understand the CONTRIBUTIONS.md file
[x] I have searched for and linked related issues
[x] I have created test cases to ensure quick resolution of the PR is easier
[x] I am NOT targeting main branch
[x] I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

Anthropic commented 7 years ago

Has one test issue I commented on the other PR, would love to see that sorted or explained as I would love to merge the content from both PR still open, thank you very much for looking into it! I've had a lot of issues raised without many PRs for a while, so I appreciate your efforts :) https://github.com/json-schema-form/angular-schema-form/pull/874#issuecomment-298174852

mnzaki commented 7 years ago

Glad to help :) I use ASF quite intensively and I think I finally know it enough to start contributing.

On a side note, the commits here are included in the other PR, I will close this as it is unnecessary (pushed and PRed too eagerly :D)