Array validation broken in Angular 1.5.10

donalmurtagh commented 7 years ago

Steps to reproduce

Open the Plunker demo
Answer "Yes" to the first question, this will reveal a savings and investments section that allows one or more account details to be entered
Problem no.1: Notice that the "Enter details of at least one account" validation message is shown, even though the account fields are pristine and I've specified that errors should not be shown for such fields via
```
sf-options="{pristine: {errors: false, success: false}}"
```
Complete all account fields
Problem no.2: Notice that the validation message remains even though all account fields are valid
Oddly, if you show and hide the savings and investments section by changing the answer to the first question to "No", then back to "Yes", the validation message disappears

If you change the Angular dependencies to 1.5.9, these problems do not occur

@json-schema-form/angular-schema-form-lead

Anthropic commented 7 years ago

Nice, a breaking change in a patch release, gotta love that. Hopefully that means it is a minor change I can manage a fix for. Thanks for finding the offending release and the clear plunks.

ivarprudnikov commented 4 years ago

Simplified Plunker version using unpkg urls: https://plnkr.co/edit/tWUx9bjwok2rrYbSeOjq

ivarprudnikov commented 4 years ago

Diff between AngularJS 1.5.9 and 1.5.10 https://github.com/angular/angular.js/compare/v1.5.9...v1.5.10

json-schema-form / angular-schema-form

Array validation broken in Angular 1.5.10 #888

Steps to reproduce