port condition loop from development branch for IE fix

json-schema-form / angular-schema-form

Generate forms from a JSON schema, with AngularJS!

https://json-schema-form.github.io/angular-schema-form

MIT License

2.47k stars 653 forks source link

port condition loop from development branch for IE fix #906

Closed Deklin closed 7 years ago

Deklin commented 7 years ago

Description

Fix for IE support of the builder.condition. Ported from your 1.0 branch.

Fixes Related issues

Checklist

[x] I have read and understand the CONTRIBUTIONS.md file
[x] I have searched for and linked related issues
[ ] I have created test cases to ensure quick resolution of the PR is easier
[x] I am NOT targeting main branch
[x] I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

Comments

The test cases we have were internal to the product we are using, but since this was ported from your 1.0 branch I would assume this is good as well.

Deklin commented 7 years ago

All set, created new PR with just the code change.

Deklin commented 7 years ago

@Anthropic thank you! If there is any chance to get a 0.8.14 bower module pushed up at some point that would be fantastic. Much appreciated all your effort on this.

Anthropic commented 7 years ago

@Deklin if you are willing to do some testing on it for me then I am, the reason it hasn't come sooner is that the 1.0.0 branch is where the unit tests are fixed and working, without tests on 0.x (which I didn't work on much) I'm terrified of releasing a "patch" that breaks anything. If I make a build on the branch would you be willing to test it for me?

Anthropic commented 7 years ago

Oh and I don't mean all the pressure will be on you ;) I will ask others also, just want to know if you have capacity to help!

Deklin commented 7 years ago

I'd be happy to, the patch I created a PR for that you merged, I can say has been well tested. If that is the only difference in whats in that support branch that is good news.

Anthropic commented 7 years ago

@Deklin great to hear, I really should try to get the tests working on that branch, but unfortunately I am time short and I am hoping that 99.9% of people will migrate to 1.0.0 when it hits beta.