replace `angular.uppercase` with `String.prototype.toUpperCase()`

json-schema-form / angular-schema-form

Generate forms from a JSON schema, with AngularJS!

https://json-schema-form.github.io/angular-schema-form

MIT License

2.47k stars 653 forks source link

replace `angular.uppercase` with `String.prototype.toUpperCase()` #976

Closed rthaut closed 6 years ago

rthaut commented 6 years ago

Description

This PR replaces the use of angular.uppercase with String.prototype.toUpperCase(), as AngularJS has removed their helper functions.

Fixes Related issues

Fixes #970

Checklist

[x] I have read and understand the CONTRIBUTIONS.md file
[x] I have searched for and linked related issues
[ ] I have created test cases to ensure quick resolution of the PR is easier
[x] I am NOT targeting main branch
[x] I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

Anthropic commented 6 years ago

Thanks Ryan, feel free to remove any other angular shortcuts you find, I personally never use vendor shortcuts, I wish I had the time to strip them all. Thanks again :)

JamesKellyBluedrop commented 6 years ago

Question.. how do I get this update into my local code. Thanks!

Anthropic commented 6 years ago

@JamesKellyBluedrop for now you'd have to copy the code change, I will try to make time to do a bump release within the next week to npm.

JamesKellyBluedrop commented 6 years ago

Thanks for getting back to me :) I did copy the change in for now and things are working again