search

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications
MIT License
625 stars 209 forks source link

draft2019-09 output-schema.json is wrong #656

Closed santhosh-tekuri closed 1 year ago

santhosh-tekuri commented 1 year ago

https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/main/output-tests/draft2019-09/output-schema.json is actually output schema from draft2020-12

you can see that at line 70 it has $dynamicRef which was not a keyword in draft 2019-09

is this intentional or copy/paste mistake?

Julian commented 1 year ago

Seems quite likely it's a copy/paste error for "$recursiveRef", though I see the 2019-09 spec just said "references" and didn't specify which keywords it meant, but seems likely to me that it meant both $ref and $recursiveRef. @gregsdennis will know for sure but yeah PR likely welcome.

gregsdennis commented 1 year ago

Very likely copy/paste, yeah. Happy to review a PR if you want to submit one, @santhosh-tekuri.

santhosh-tekuri commented 1 year ago

Fixed with ce2c165