Test early placement of unevaluatedItems|Properties with $ref

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications

MIT License

625 stars 209 forks source link

Test early placement of unevaluatedItems|Properties with $ref #706

Closed marksparkza closed 10 months ago

marksparkza commented 1 year ago

Follows on from https://github.com/json-schema-org/JSON-Schema-Test-Suite/commit/8ba1c90dc62b9ddd6c2efc2c395d122a8d68135d, which produced test failures in my implementation. I had the same problem with the changes in this PR, which puts unevaluated* before $ref.

gregsdennis commented 1 year ago

Instead of reordering existing tests, should we create separate tests to cover specifically this issue? If someone else has had problems with the current ordering, you're removing their sanity tests.

marksparkza commented 1 year ago

Fair point. I'm happy to redo as separate tests.

Julian commented 10 months ago

Is there anything this PR was waiting on that made it not be merged? I'm going to assume "no" and merge it given it's been sitting here and has multiple approvals.