search

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications
MIT License
603 stars 205 forks source link

Move tests with ids in non-schemas to optional #707

Closed jdesrosiers closed 7 months ago

jdesrosiers commented 8 months ago

Resolves #700

This moves any tests that reference into locations not known to be a schema to the "optional" folder.

karenetheridge commented 8 months ago

I don't understand why this is being done -- are you expecting that implementations could either pass or fail these tests? But some of the things being tested here are mandatory -- such as that keywords that look like identifiers in non-schemas MUST NOT be treated as real identifiers. That's different from simply $ref-ing into non-schemas (which has undefined behaviour in the spec).

gregsdennis commented 8 months ago

@karenetheridge would you then expect only the tests which have pointer $refs that go into non-schema locations be moved to optional? That would leave any tests which use $id-based $refs in required.

karenetheridge commented 8 months ago

Yes, and I thought we'd already done that - because optional/refOfUnknownKeyword.json already exists.

jdesrosiers commented 8 months ago

Let's keep discussion in #700. @karenetheridge and @gregsdennis, I'd like to hear what you think about my last comment.