update the test suite for draft-next

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications

MIT License

603 stars 205 forks source link

update the test suite for draft-next #725

Closed hauner closed 3 months ago

hauner commented 3 months ago

not all tests align with the draft-next schemas

gregsdennis commented 3 months ago

Can you provide details of misaligned tests that you've found, please? Just saying "it's wrong" isn't particularly helpful.

hauner commented 3 months ago

draft-next/id.json

"Valid use of empty fragments in location-independent $id"/"Identifier name with absolute URI" is not valid anymore because the ˋ$idˋ pattern changed in core.json

that is the only one I checked 😉 I stopped after you mentioned that the tests are not up to date...

I can check my other failing tests if it helps.

notEthan commented 3 months ago

That test is dropped by https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/718 (merged just now). Any other problems?

hauner commented 3 months ago

I'm down to two test failures (unevaluatedProperties/propertyDependencies) implementing draft-next, so I think there is no "wrong" test anymore.

I wonder if there are missing tests though. draft-next talks about

"contains", "minContains", and "maxContains" now apply to objects as well as arrays"

and I expected some failing tests for the object case but there are none.

contains.json has a few changes but I don't see any tests explicitly on objects.

gregsdennis commented 3 months ago

contains applied to objects for a short time, but we decided not to do that.

Honestly, I wouldn't worry about getting draft-next right now. It's not published, and there's clearly work to be done. We're going to have to go through it carefully before publication.

Julian commented 3 months ago

Sounds like we should close this then. If you have specific issues nonetheless (of tests which don't match the spec text), open those please.