search

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications
MIT License
603 stars 205 forks source link

Adding test for $dynamicRef contain json pointer #730

Closed MeastroZI closed 3 months ago

MeastroZI commented 3 months ago

Test for the $dynamicRef contain json pointer, addressing issue #600 .

MeastroZI commented 3 months ago

@gregsdennis can you please review this PR

gregsdennis commented 3 months ago

@MeastroZI please don't tag us pre-emptively. We're notified of the PR merely by you opening it. If something is urgent, you're welcome to contact us in Slack.

MeastroZI commented 3 months ago

I'm really sorry, Greg Dennis I opened this PR because I found issue #600 and wanted to help out in the repo. I've been trying to be more active here since I couldn't contribute much before the application deadline due to joining late and working on qualification tasks. But in the rush, I forgot that I might be making things tougher for the mentors :disappointed_relieved: . Sorry about that.

Matthew Adams and Greg Dennis Feel free to close this PR or requests any changes you think are needed .

MeastroZI commented 3 months ago

As the test proposed by this PR seems to be a duplicate, I am closing it. However, clarification on issue #600 would be appreciated. If the issue has been resolved, it can be closed. Thank you