search

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications
MIT License
615 stars 205 forks source link

Add valid first character to avoid Bidi rule violation in Arabic-Indic digits test #734

Closed OptimumCode closed 5 months ago

OptimumCode commented 5 months ago

Hello, this PR resolves #737

OptimumCode commented 5 months ago

I am sorry, I probably should have created an issue first...

If the issue is required - please, let me know. I will create it and link it to the PR

OptimumCode commented 5 months ago

Issue has been created

gregsdennis commented 5 months ago

I ran these against my implementation, and it seems my implementation apparently doesn't do IDN hostname validation well: these fail both before and after the changes for me. (It's fine, they're optional.)

mwadams commented 5 months ago

I pass the previous IDN hostname tests. I'll give this one a go tomorrow.

OptimumCode commented 5 months ago

I pass the previous IDN hostname tests. I'll give this one a go tomorrow.

Hi, @mwadams. Could you please advise if you had a chance to try the updated test case?

mwadams commented 5 months ago

Hi - I can confirm that Corvus.JsonSchema still passes the test with this change.