Open MeastroZI opened 7 months ago
But then description need to be change for this
{
"description": "when if is true and has no unevaluated properties",
"data": {
"foo": "then",
"bar": "bar"
},
"valid": false
}
as bar is unevaluated , if we change the description it will become duplicate of other test
If i am not wong currently this test is duplicate of this one
{
"description": "when if is true and has unevaluated properties",
"data": {
"foo": "then",
"bar": "bar",
"baz": "baz"
},
"valid": false
},
I think @MeastroZI was right the first time. The original test should be modified because it's just a duplicate of another test. Changing the test makes it cover a unique case and what it was testing is already covered elsewhere.
No worries. I was on mobile and hadn't checked other tests. Sorry for the confusion.
https://github.com/json-schema-org/JSON-Schema-Test-Suite/issues/723
I think removing the bar matches the test with the description, as foo itself is evaluated.