search

json-schema-org / JSON-Schema-Test-Suite

A language agnostic test suite for the JSON Schema specifications
MIT License
625 stars 209 forks source link

All format test cases should be under the `format` directory. #751

Closed big-andy-coates closed 2 months ago

big-andy-coates commented 5 months ago

fixes: https://github.com/creek-service/json-schema-validation-comparison/issues/190

Currently, there exists an ecma regex test case, that uses "format": "regex", but which does not live under the optional/format directory.

My understanding was that all tests that require format validation from implementations where under the optional/format directory. (As per point #2 under the Additional Assumptions section of the docs).

Having this one test case outside of the directory complicates the implementations of all test runners and the need to turn on format validation for this one test case isn't even documented.

As such, this change moves the test requiring format under the optional/format directory.

This change was prompted by: https://github.com/creek-service/json-schema-validation-comparison/issues/190

big-andy-coates commented 3 months ago

@karenetheridge is there something stopping this being merged?

big-andy-coates commented 2 months ago

@karenetheridge is there something stopping this being merged?

karenetheridge commented 2 months ago

Apologies, my mail filter for mentions was broken so I didn't see the nudges previously.

this is good to go, so merging!

big-andy-coates commented 1 month ago

No worries - thanks for merging.