search

json-schema-org / json-schema-spec

The JSON Schema specification
http://json-schema.org/
Other
3.69k stars 260 forks source link

Update spec to disallow unknown keywords #1340

Closed gregsdennis closed 3 months ago

gregsdennis commented 1 year ago

Following @handrews' discussion on disallowing non-vocab keywords, we decided that this is a feature that we want in order to help guarantee forward compability.

The spec needs to be updated accordingly.

handrews commented 1 year ago

We did? I mean, I'm all for it! I just didn't realize there was consensus. There should probably be an ADR first as this is a pretty big deal, and there are some details to nail down.

gregsdennis commented 1 year ago

As far as I could tell from the proposal, I felt that we all seemed to agree on doing it.

Others are, of course, encouraged to speak up.

handrews commented 1 year ago

I can probably write it up as an ADR easily enough (the conversation wasn't that lengthy so I'll just do a bit of cut/paste/edit) and we can have an official PR for sign-off. If we're all in agreement it should go quickly anyway.

jdesrosiers commented 1 year ago

There should probably be an ADR

The ADR I'm going to write will cover that we are committing to forward compatibility, but I don't think it will cover the specific changes (like this issue) that need to happen to make that possible. So, if you write an ADR specifically for this issue, I think there would be some overlap, but it could still make sense as a separate ADR.

handrews commented 1 year ago

@jdesrosiers sounds good- I'm basically planning to just edit that discussion into a document. I don't plan on addressing the larger forwards compatibility topic, it would just be assumed from the SDLC and could link to the ADR for that.