search

json-schema-org / json-schema-spec

The JSON Schema specification
http://json-schema.org/
Other
3.82k stars 266 forks source link

Strengthen requirements on optional vocabularies and unknown keywords #1376

Closed handrews closed 1 year ago

handrews commented 1 year ago

This fixes #1300, and has been posted to clear up confusion over the difference between it and #1294 / #1295.

The explanation is in #1300, and if there is any controversy over this, or a desire to split the the two SHOULD-to-MUST changes to accept one and reject the other, then this draft PR should be closed unmerged and the discussion should take place in issue #1300. If this happens, anyone should feel free to close this- there is no need to check with me first.

This strengthens two SHOULDs to MUSTS:

handrews commented 1 year ago

See also https://github.com/orgs/json-schema-org/discussions/295#discussioncomment-4721326, issue #1340, and https://github.com/orgs/json-schema-org/discussions/241 for related ideas, some of which are compatible and others are incompatible.

gregsdennis commented 1 year ago

Closing this as

  1. We are discussing the viability of optional vocabularies in light of...
  2. Unknown keywords are now disallowed.

As such, this PR is moot.