search

json-schema-org / json-schema-spec

The JSON Schema specification
http://json-schema.org/
Other
3.43k stars 251 forks source link

Extract vocabularies from the specs #1510

Open gregsdennis opened 1 month ago

gregsdennis commented 1 month ago

Relates to https://github.com/orgs/json-schema-org/discussions/724 and https://github.com/json-schema-org/json-schema-spec/pull/1505.

Depends on #1518 Depends on #1512 (will likely need rebase after those merge)

The Core spec was a lot, but it was fairly straightforward.

This PR will make a best effort to include vocabularies as they are in 2020-12 as a start. Some redesign is inevitible, but this this is a good starting point.

gregsdennis commented 1 month ago

Yes, the word was present, but it was used very loosely. Later we added it with a very specific (and vaguely different) meaning but didn't address the existing usages. (See https://json-schema.org/draft-07/json-schema-validation.)

I figure it's better for now to just remove it completely. I don't think that the text suffers.

jdesrosiers commented 1 month ago

I figure it's better for now to just remove it completely. I don't think that the text suffers.

That's fine with me. I didn't think the text suffered, I was just trying to make this a smaller job :smile:.

gregsdennis commented 2 weeks ago

Reminder (to me): open a new issue to discuss the future of the keyword and link all of the issues I've been linking ☝️

gregsdennis commented 2 weeks ago

I've rebased this on top of #1512. Starting to address comments now.