json-schema-org / referencing

Proposals for a possible specification encompassing the varying uses of "$ref"
MIT License
6 stars 1 forks source link

New proposal: JSON Referencing and Identification (JRI) #2

Closed handrews closed 2 years ago

handrews commented 2 years ago

Note: This PR will be up for a minimum of 14 days. If we are nearing that and you want an extra couple of days to comment, please just comment with an estimate of how much additional time you need.

What this PR is about

As a "new proposal PR", this PR is for accepting a baseline from which to start discussions. As noted in the README, merging this PR does not indicate an endorsement by the JSON Schema Org, nor does it necessarily mean that it will ever be submitted to the IETF. Those things depend on the outcome of further discussions of this and other proposals.

Therefore for this and other such PRs (we expect at least one more in this repo):

Please do!

Please do not...

How to view the file

While there are numerous commits here, that is mostly for the folks who saw an early version of this who want to see how I re-organized it since that version. Otherwise you can ignore the commits and just review the file as of the most recent commit.

See the repository README for documentation of the Markdown RFC format. A few key points:

handrews commented 2 years ago

@gregsdennis I think I have addressed each of your comments with either a change, an explanation, or a question as to how to proceed. Please let me know if I missed anything, and thank you for the speedy review!

handrews commented 2 years ago

@DavidBiesack I think I have addressed all of your comments that we did not move off to separate issues. Please take a look. Since this has been open for 14 days, once you have signed off I will merge this unless something else has come up. We will continue to discuss things in issues and all are welcome to file such issues after the merge.

handrews commented 2 years ago

OK, @gregsdennis I think I have now addressed everything- thanks for the IM about the ones that GitHub had "conveniently" hidden.

handrews commented 2 years ago

@DavidBiesack thanks for the speedy review! I think I have addressed everything you raised- I have no idea how I missed the $extRef comment in particular, this PR has gotten rather confusing to follow in the UI (I missed a comment or two of @gregsdennis's as well despite going over everything multiple times). Please let me know if this is insufficient or if you notice other things I have missed. I did kind of rush this most recent update.

handrews commented 2 years ago

@DavidBiesack @gregsdennis thanks! I have fixed the word 🤦