search

json-schema-org / upgrade-downgrade-rules

A set of transformation rules to convert between JSON Schema specification versions
Other
2 stars 1 forks source link

Research upgrade behavior for the format keyword #6

Closed suprith-hub closed 5 months ago

suprith-hub commented 5 months ago

I have converted the same information in the docs to the markdown, maybe the view can be optimized, ... I have used tables and headings, anchors etc..

jviotti commented 5 months ago

As an initial observation, try to write better commit subjects. Some quick Googling reveals this guide, that seems decent: https://cbea.ms/git-commit/

Your current commit subject says "1st commit" which should not be on the commit itself (as git itself will determine the ordering depending on what gets merged when) and in fact this it not even the first commit (so it's a lie). Plus "research on Format" is a bit vague.

A better commit subject here would have been (in imperative mood): "Research upgrade behavior for the format keyword" or something like that

suprith-hub commented 5 months ago

@jviotti I have made the changes

suprith-hub commented 5 months ago

@jviotti I have made the changes

suprith-hub commented 5 months ago

@jviotti the changes are done