json-schema-org / website

JSON Schema website
https://json-schema.org
Other
66 stars 173 forks source link

🐛 Bug: Search and remove `any` from codebase #1034

Open DhairyaMajmudar opened 3 weeks ago

DhairyaMajmudar commented 3 weeks ago

Describe the bug

-> While performing a quick VS Code search its found that there are several places in the codebase where any datatype is used, -> Using any in place of correct data type alters the strictness of typescript hence its a not a good practice to use them.

-> The main objective of this issue is to find the files where any keyword is used and replace them with the correct data type definition.

Steps To Reproduce

Do a VSCode Search to find the files using any keyword. They are mostly used in component files

Expected Behavior

There should be no use of any keyword in the codebase

Screenshots

No response

Device Information [optional]

- OS: Linux (Debian)
- Browser: Firefox
- version: Latest

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

Asymtode712 commented 3 weeks ago

@DhairyaMajmudar I would like to work on this issue.....Please assign it to me

DhairyaMajmudar commented 3 weeks ago

@DhairyaMajmudar I would like to work on this issue.....Please assign it to me

Looking forward for your PR, also at some instances you might need to create a custom data type at that moment pls. take care with the naming, Best wishes 🚀

Asymtode712 commented 3 weeks ago

@DhairyaMajmudar I am done with most of the components....I have a doubt: Do I need to remove the any keywords from the pages directory too....

DhairyaMajmudar commented 3 weeks ago

@DhairyaMajmudar I am done with most of the components....I have a doubt: Do I need to remove the any keywords from the pages directory too....

yep, if those files have any keyword then pls. remove from there also.